ppapi/native_client/src/trusted/plugin/service_runtime.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/src/trusted/plugin/service_runtime.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/native_client/src/trusted/plugin/service_runtime.cc

diff --git a/ppapi/native_client/src/trusted/plugin/service_runtime.cc b/ppapi/native_client/src/trusted/plugin/service_runtime.cc

index 00f64c767f6a178878b54eb5f95f40076d8f65af..68a50d30e4bdd039d720f39f1216aa9502a7c4f5 100644

--- a/ppapi/native_client/src/trusted/plugin/service_runtime.cc

+++ b/ppapi/native_client/src/trusted/plugin/service_runtime.cc

@@ -846,7 +846,7 @@ nacl::string ServiceRuntime::GetCrashLogOutput() {

if (NULL != subprocess_.get()) {

return subprocess_->GetCrashLogOutput();

} else {

- return "";

+ return std::string();

}