net/quic/quic_packet_creator_test.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_packet_creator_test.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/quic_packet_creator_test.cc

diff --git a/net/quic/quic_packet_creator_test.cc b/net/quic/quic_packet_creator_test.cc

index 5e7ed613cc7336f7ec2a33ce4cd403d50d3bb33a..2f4e2e9a59fb639c8eff97b758e4cd78262656c9 100644

--- a/net/quic/quic_packet_creator_test.cc

+++ b/net/quic/quic_packet_creator_test.cc

@@ -180,7 +180,7 @@ TEST_F(QuicPacketCreatorTest, CreateStreamFrameFinOnly) {

QuicFrame frame;

size_t consumed = creator_.CreateStreamFrame(1u, "", 0u, true, &frame);

EXPECT_EQ(0u, consumed);

- CheckStreamFrame(frame, 1u, "", 0u, true);

+ CheckStreamFrame(frame, 1u, std::string(), 0u, true);

delete frame.stream_frame;

}