net/http/http_vary_data_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_vary_data_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_vary_data_unittest.cc

diff --git a/net/http/http_vary_data_unittest.cc b/net/http/http_vary_data_unittest.cc

index 38e4e325c9969243509c7e2ea0e08ca0b46752d6..93ee4f45aee045befb721cf81a070c66c9f08429 100644

--- a/net/http/http_vary_data_unittest.cc

+++ b/net/http/http_vary_data_unittest.cc

@@ -41,7 +41,7 @@ TEST(HttpVaryDataTest, IsInvalid) {

for (size_t i = 0; i < arraysize(kTestResponses); ++i) {

TestTransaction t;

- t.Init("", kTestResponses[i]);

+ t.Init(std::string(), kTestResponses[i]);

net::HttpVaryData v;

EXPECT_FALSE(v.is_valid());