Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1143)

Unified Diff: chrome/test/webdriver/webdriver_key_converter.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/webdriver/webdriver_key_converter.cc
diff --git a/chrome/test/webdriver/webdriver_key_converter.cc b/chrome/test/webdriver/webdriver_key_converter.cc
index e19e9dc73ac8846aaaffa3968d791b3eae6ac9a2..b83d3cb75b36340a8d43ce3a8d32a2609f173ff9 100644
--- a/chrome/test/webdriver/webdriver_key_converter.cc
+++ b/chrome/test/webdriver/webdriver_key_converter.cc
@@ -162,11 +162,19 @@ bool KeyCodeFromShorthandKey(char16 key_utf16,
namespace webdriver {
WebKeyEvent CreateKeyDownEvent(ui::KeyboardCode key_code, int modifiers) {
- return WebKeyEvent(automation::kRawKeyDownType, key_code, "", "", modifiers);
+ return WebKeyEvent(automation::kRawKeyDownType,
+ key_code,
+ std::string(),
+ std::string(),
+ modifiers);
}
WebKeyEvent CreateKeyUpEvent(ui::KeyboardCode key_code, int modifiers) {
- return WebKeyEvent(automation::kKeyUpType, key_code, "", "", modifiers);
+ return WebKeyEvent(automation::kKeyUpType,
+ key_code,
+ std::string(),
+ std::string(),
+ modifiers);
}
WebKeyEvent CreateCharEvent(const std::string& unmodified_text,

Powered by Google App Engine
This is Rietveld 408576698