Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/extension_test_message_listener.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/nix/mime_util_xdg.cc ('K') | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/extensions_quota_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_test_message_listener.cc
diff --git a/chrome/browser/extensions/extension_test_message_listener.cc b/chrome/browser/extensions/extension_test_message_listener.cc
index 90aa01affc5383407f2492c81dbcaa11ade82f1d..e892ba170726325004fee2004cc29b865680c5a0 100644
--- a/chrome/browser/extensions/extension_test_message_listener.cc
+++ b/chrome/browser/extensions/extension_test_message_listener.cc
@@ -17,7 +17,6 @@ ExtensionTestMessageListener::ExtensionTestMessageListener(
satisfied_(false),
waiting_(false),
will_reply_(will_reply),
- failure_message_(""),
failed_(false) {
registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_TEST_MESSAGE,
content::NotificationService::AllSources());
@@ -59,7 +58,7 @@ void ExtensionTestMessageListener::Observe(
satisfied_ = true;
registrar_.RemoveAll(); // Stop listening for more messages.
if (!will_reply_) {
- function_->Reply("");
+ function_->Reply(std::string());
function_ = NULL;
}
if (waiting_) {
« base/nix/mime_util_xdg.cc ('K') | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/extensions_quota_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698