content/test/gpu/gpu_test_config_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/gpu/gpu_test_config_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/test/gpu/gpu_test_config_unittest.cc

diff --git a/content/test/gpu/gpu_test_config_unittest.cc b/content/test/gpu/gpu_test_config_unittest.cc

index f58139f8ddc048f575f072d13bf2581119e01029..a87d215383754c426ebe082d957476e63c60af81 100644

--- a/content/test/gpu/gpu_test_config_unittest.cc

+++ b/content/test/gpu/gpu_test_config_unittest.cc

@@ -148,7 +148,7 @@ TEST_F(GPUTestConfigTest, StringMatches) {

config.set_gpu_device_id(0x0640);

EXPECT_TRUE(config.IsValid());

- EXPECT_TRUE(config.Matches(""));

+ EXPECT_TRUE(config.Matches(std::string()));

// os matching

EXPECT_TRUE(config.Matches("WIN"));