chrome/browser/ui/webui/extensions/pack_extension_handler.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/pack_extension_handler.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/extensions/pack_extension_handler.cc

diff --git a/chrome/browser/ui/webui/extensions/pack_extension_handler.cc b/chrome/browser/ui/webui/extensions/pack_extension_handler.cc

index a69cd4d721ce054294c578d32dbd0af42b627148..0623fda581b2533480731e74995b435f1169d783 100644

--- a/chrome/browser/ui/webui/extensions/pack_extension_handler.cc

+++ b/chrome/browser/ui/webui/extensions/pack_extension_handler.cc

@@ -184,8 +184,12 @@ void PackExtensionHandler::HandleSelectFilePathMessage(

load_extension_dialog_ = ui::SelectFileDialog::Create(

this, new ChromeSelectFilePolicy(web_ui()->GetWebContents()));

load_extension_dialog_->SelectFile(

- type, select_title, base::FilePath(), &info, file_type_index,

- FILE_PATH_LITERAL(""),

+ type,

+ select_title,

+ base::FilePath(),

+ &info,

+ file_type_index,

+ FILE_PATH_LITERAL(std::string()),

web_ui()->GetWebContents()->GetView()->GetTopLevelNativeWindow(),

NULL);

}