net/socket/deterministic_socket_data_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/deterministic_socket_data_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/deterministic_socket_data_unittest.cc

diff --git a/net/socket/deterministic_socket_data_unittest.cc b/net/socket/deterministic_socket_data_unittest.cc

index a007e3617aaa089cf2e2f35c1cd11d259c71d538..aea81603f9bce77f9032c5a270fdf567b9b630ae 100644

--- a/net/socket/deterministic_socket_data_unittest.cc

+++ b/net/socket/deterministic_socket_data_unittest.cc

@@ -77,9 +77,8 @@ DeterministicSocketDataTest::DeterministicSocketDataTest()

false,

OnHostResolutionCallback())),

- histograms_(""),

- socket_pool_(10, 10, &histograms_, &socket_factory_) {

+ histograms_(std::string()),

+ socket_pool_(10, 10, &histograms_, &socket_factory_) {}

void DeterministicSocketDataTest::TearDown() {

// Empty the current queue.