Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: chrome/common/extensions/extension_localization_peer_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension_localization_peer_unittest.cc
diff --git a/chrome/common/extensions/extension_localization_peer_unittest.cc b/chrome/common/extensions/extension_localization_peer_unittest.cc
index 92085ed84197da503eadb42fbde8c0294e37c22b..df747919fb85844d80e26ddfb1668fd2d9d6e646 100644
--- a/chrome/common/extensions/extension_localization_peer_unittest.cc
+++ b/chrome/common/extensions/extension_localization_peer_unittest.cc
@@ -144,8 +144,8 @@ TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestBadURLRequestStatus) {
EXPECT_CALL(*original_peer_, OnCompletedRequest(
net::ERR_ABORTED, false, "", base::TimeTicks()));
- filter_peer->OnCompletedRequest(net::ERR_FAILED, false, "",
- base::TimeTicks());
+ filter_peer->OnCompletedRequest(
+ net::ERR_FAILED, false, std::string(), base::TimeTicks());
}
TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestEmptyData) {
@@ -159,7 +159,8 @@ TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestEmptyData) {
EXPECT_CALL(*original_peer_, OnCompletedRequest(
net::OK, false, "", base::TimeTicks()));
- filter_peer->OnCompletedRequest(net::OK, false, "", base::TimeTicks());
+ filter_peer->OnCompletedRequest(
+ net::OK, false, std::string(), base::TimeTicks());
}
TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestNoCatalogs) {
@@ -178,14 +179,16 @@ TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestNoCatalogs) {
EXPECT_CALL(*original_peer_, OnCompletedRequest(
net::OK, false, "", base::TimeTicks())).Times(2);
- filter_peer->OnCompletedRequest(net::OK, false, "", base::TimeTicks());
+ filter_peer->OnCompletedRequest(
+ net::OK, false, std::string(), base::TimeTicks());
// Test if Send gets called again (it shouldn't be) when first call returned
// an empty dictionary.
filter_peer =
CreateExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1));
SetData(filter_peer, "some text");
- filter_peer->OnCompletedRequest(net::OK, false, "", base::TimeTicks());
+ filter_peer->OnCompletedRequest(
+ net::OK, false, std::string(), base::TimeTicks());
}
TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestWithCatalogs) {
@@ -213,7 +216,8 @@ TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestWithCatalogs) {
EXPECT_CALL(*original_peer_, OnCompletedRequest(
net::OK, false, "", base::TimeTicks()));
- filter_peer->OnCompletedRequest(net::OK, false, "", base::TimeTicks());
+ filter_peer->OnCompletedRequest(
+ net::OK, false, std::string(), base::TimeTicks());
}
TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestReplaceMessagesFails) {
@@ -241,5 +245,6 @@ TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestReplaceMessagesFails) {
EXPECT_CALL(*original_peer_, OnCompletedRequest(
net::OK, false, "", base::TimeTicks()));
- filter_peer->OnCompletedRequest(net::OK, false, "", base::TimeTicks());
+ filter_peer->OnCompletedRequest(
+ net::OK, false, std::string(), base::TimeTicks());
}

Powered by Google App Engine
This is Rietveld 408576698