remoting/host/host_change_notification_listener_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/host_change_notification_listener_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/host/host_change_notification_listener_unittest.cc

diff --git a/remoting/host/host_change_notification_listener_unittest.cc b/remoting/host/host_change_notification_listener_unittest.cc

index 1f9305eb2c917a9133d48a19e0282e2b2a256225..5ec6ff8a40e46d6629bcd4ea6167a5d0973e30e1 100644

--- a/remoting/host/host_change_notification_listener_unittest.cc

+++ b/remoting/host/host_change_notification_listener_unittest.cc

@@ -69,9 +69,9 @@ class HostChangeNotificationListenerTest : public testing::Test {

std::string hostId,

std::string botJid) {

scoped_ptr<XmlElement> stanza(new XmlElement(buzz::QN_IQ));

- stanza->AddAttr(QName("", "type"), "set");

- XmlElement* host_changed = new XmlElement(

- QName(kChromotingXmlNamespace, "host-changed"));

+ stanza->AddAttr(QName(std::string(), "type"), "set");

+ XmlElement* host_changed =

+ new XmlElement(QName(kChromotingXmlNamespace, "host-changed"));

host_changed->AddAttr(QName(kChromotingXmlNamespace, "operation"),

operation);

host_changed->AddAttr(QName(kChromotingXmlNamespace, "hostid"), hostId);