chrome/test/webdriver/keycode_text_conversion_gtk.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/webdriver/keycode_text_conversion_gtk.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/webdriver/keycode_text_conversion_gtk.cc

diff --git a/chrome/test/webdriver/keycode_text_conversion_gtk.cc b/chrome/test/webdriver/keycode_text_conversion_gtk.cc

index 05b17db71d138a9434164853f1517de87310ae7a..302d708a75ff3d6e1948e186ed849155fb62c454 100644

--- a/chrome/test/webdriver/keycode_text_conversion_gtk.cc

+++ b/chrome/test/webdriver/keycode_text_conversion_gtk.cc

@@ -23,7 +23,7 @@ std::string ConvertKeyCodeToText(ui::KeyboardCode key_code, int modifiers) {

gdk_key_code = gdk_keyval_to_upper(gdk_key_code);

guint32 unicode_char = gdk_keyval_to_unicode(gdk_key_code);

if (!unicode_char)

- return "";

+ return std::string();

gchar buffer[6];

gint length = g_unichar_to_utf8(unicode_char, buffer);

return std::string(buffer, length);