net/test/base_test_server.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/test/base_test_server.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/test/base_test_server.cc

diff --git a/net/test/base_test_server.cc b/net/test/base_test_server.cc

index 3a2dc11ed886e25c610e4ee15d080c7e73750afa..ab9b1210d8573cd5d7e8d27526a00371037205a0 100644

--- a/net/test/base_test_server.cc

+++ b/net/test/base_test_server.cc

@@ -92,7 +92,7 @@ base::FilePath BaseTestServer::SSLOptions::GetCertificateFile() const {

std::string BaseTestServer::SSLOptions::GetOCSPArgument() const {

if (server_certificate != CERT_AUTO)

- return "";

+ return std::string();

switch (ocsp_status) {

case OCSP_OK:

@@ -107,7 +107,7 @@ std::string BaseTestServer::SSLOptions::GetOCSPArgument() const {

return "unknown";

default:

NOTREACHED();

- return "";

+ return std::string();

}