chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc

diff --git a/chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc b/chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc

index 2ee22c328badf4ba2715f60bf48b960e3b87b24e..844f210782cc5fd7b5b68a3f7f68310bf53e0cae 100644

--- a/chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc

+++ b/chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc

@@ -110,10 +110,8 @@ void BlockedContentTabHelper::AddPopup(content::WebContents* new_contents,

if (creator.is_valid() &&

profile->GetHostContentSettingsMap()->GetContentSetting(

- creator,

- CONTENT_SETTINGS_TYPE_POPUPS,

- "") == CONTENT_SETTING_ALLOW) {

+ creator, creator, CONTENT_SETTINGS_TYPE_POPUPS, std::string()) ==

+ CONTENT_SETTING_ALLOW) {

content::WebContentsDelegate* delegate = web_contents()->GetDelegate();

if (delegate) {

delegate->AddNewContents(web_contents(),