chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc

diff --git a/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc b/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc

index 3237137d2b2318262381b156321384b542123d7b..aa4799202bf417072d53b75cd248a3b7e0887692 100644

--- a/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc

+++ b/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc

@@ -167,7 +167,7 @@ TEST(TemplateURLPrepopulateDataTest, ProvidersFromPrefs) {

entry->SetInteger("id", 1002);

entry->SetString("name", "bar");

entry->SetString("keyword", "bark");

- entry->SetString("encoding", "");

+ entry->SetString("encoding", std::string());

overrides->Append(entry->DeepCopy());

entry->SetInteger("id", 1003);

entry->SetString("name", "baz");

« base/nix/mime_util_xdg.cc ('K') | « chrome/browser/search/search_unittest.cc ('k') | chrome/browser/sessions/session_restore_browsertest.cc » ('j') | no next file with comments »