chrome/renderer/extensions/resource_request_policy.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/resource_request_policy.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/resource_request_policy.cc

diff --git a/chrome/renderer/extensions/resource_request_policy.cc b/chrome/renderer/extensions/resource_request_policy.cc

index 116b218d1541e1e3319044924f177c73ac3c09ff..83ccb3f7330d043bbb2740036b856a092da13cdc 100644

--- a/chrome/renderer/extensions/resource_request_policy.cc

+++ b/chrome/renderer/extensions/resource_request_policy.cc

@@ -51,7 +51,8 @@ bool ResourceRequestPolicy::CanRequestResource(

// some extensions want to be able to do things like create their own

// launchers.

std::string resource_root_relative_path =

- resource_url.path().empty() ? "" : resource_url.path().substr(1);

+ resource_url.path().empty() ? std::string()

+ : resource_url.path().substr(1);

if (extension->is_hosted_app() &&

!IconsInfo::GetIcons(extension)

.ContainsPath(resource_root_relative_path)) {