chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc

diff --git a/chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc b/chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc

index 4b003cf00c66b635139edf0fe480bbc310eda7ce..4115f187f6d9f2b8dbf94da6334f34694dbf7b89 100644

--- a/chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc

+++ b/chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc

@@ -43,7 +43,7 @@ Profile* TabContentsSyncedTabDelegate::profile() const {

std::string TabContentsSyncedTabDelegate::GetExtensionAppId() const {

const scoped_refptr<const extensions::Extension> extension_app(

extensions::TabHelper::FromWebContents(web_contents_)->extension_app());

- return (extension_app.get() ? extension_app->id() : "");

+ return (extension_app.get() ? extension_app->id() : std::string());

}

int TabContentsSyncedTabDelegate::GetCurrentEntryIndex() const {