Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Unified Diff: chrome/browser/media_galleries/media_galleries_dialog_controller.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media_galleries/media_galleries_dialog_controller.cc
diff --git a/chrome/browser/media_galleries/media_galleries_dialog_controller.cc b/chrome/browser/media_galleries/media_galleries_dialog_controller.cc
index 98ba8daaec6415f1f95b40fba73e5a79c3cce9f1..27b876587edfe9787f6f72678daa47548355ec76 100644
--- a/chrome/browser/media_galleries/media_galleries_dialog_controller.cc
+++ b/chrome/browser/media_galleries/media_galleries_dialog_controller.cc
@@ -147,7 +147,7 @@ string16 MediaGalleriesDialogController::GetHeader() const {
}
string16 MediaGalleriesDialogController::GetSubtext() const {
- std::string extension_name(extension_ ? extension_->name() : "");
+ std::string extension_name(extension_ ? extension_->name() : std::string());
return l10n_util::GetStringFUTF16(IDS_MEDIA_GALLERIES_DIALOG_SUBTEXT,
UTF8ToUTF16(extension_name));
}
@@ -184,7 +184,9 @@ void MediaGalleriesDialogController::OnAddFolderClicked() {
ui::SelectFileDialog::SELECT_FOLDER,
l10n_util::GetStringUTF16(IDS_MEDIA_GALLERIES_DIALOG_ADD_GALLERY_TITLE),
user_data_dir,
- NULL, 0, FILE_PATH_LITERAL(""),
+ NULL,
+ 0,
+ FILE_PATH_LITERAL(std::string()),
web_contents_->GetView()->GetTopLevelNativeWindow(),
NULL);
}

Powered by Google App Engine
This is Rietveld 408576698