net/base/dns_util.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/dns_util.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/dns_util.cc

diff --git a/net/base/dns_util.cc b/net/base/dns_util.cc

index 816095b0bd8156c24532bc2d52682704a799d1a7..b94eff8980a492968033bda506b0c96f2586fa06 100644

--- a/net/base/dns_util.cc

+++ b/net/base/dns_util.cc

@@ -62,16 +62,16 @@ std::string DNSDomainToString(const base::StringPiece& domain) {

for (unsigned i = 0; i < domain.size() && domain[i]; i += domain[i] + 1) {

#if CHAR_MIN < 0

if (domain[i] < 0)

- return "";

+ return std::string();

#endif

if (domain[i] > 63)

- return "";

+ return std::string();

if (i)

ret += ".";

if (static_cast<unsigned>(domain[i]) + i + 1 > domain.size())

- return "";

+ return std::string();

domain.substr(i + 1, domain[i]).AppendToString(&ret);

}