chrome/browser/sync/glue/session_model_associator_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/session_model_associator_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/glue/session_model_associator_unittest.cc

diff --git a/chrome/browser/sync/glue/session_model_associator_unittest.cc b/chrome/browser/sync/glue/session_model_associator_unittest.cc

index d1f63bbe1fac20d3fedc5a1e8e1343da5668d5ce..7c34ac25a703d5d897b8b85a63c0d79610436171 100644

--- a/chrome/browser/sync/glue/session_model_associator_unittest.cc

+++ b/chrome/browser/sync/glue/session_model_associator_unittest.cc

@@ -375,7 +375,7 @@ TEST_F(SyncSessionModelAssociatorTest, SetSessionTabFromDelegate) {

// Create tab specifics with an empty favicon. Ensure it gets ignored and not

// stored into the synced favicon lookups.

TEST_F(SyncSessionModelAssociatorTest, LoadEmptyFavicon) {

- std::string favicon = "";

+ std::string favicon = std::string();

std::string favicon_url = "http://www.faviconurl.com/favicon.ico";

std::string page_url = "http://www.faviconurl.com/page.html";

sync_pb::SessionTab tab;