chrome/browser/extensions/subscribe_page_action_browsertest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/subscribe_page_action_browsertest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/subscribe_page_action_browsertest.cc

diff --git a/chrome/browser/extensions/subscribe_page_action_browsertest.cc b/chrome/browser/extensions/subscribe_page_action_browsertest.cc

index 471ad5c2e0cae81995b0cc8e105de17f0a598387..02449a18e91c0b5fdbb6ff5d4f25e70e0f4cc41e 100644

--- a/chrome/browser/extensions/subscribe_page_action_browsertest.cc

+++ b/chrome/browser/extensions/subscribe_page_action_browsertest.cc

@@ -114,10 +114,8 @@ void NavigateToFeedAndValidate(net::TestServer* server,

GetFeedUrl(server, url, true, extension_id));

WebContents* tab = browser->tab_strip_model()->GetActiveWebContents();

- ASSERT_TRUE(ValidatePageElement(tab,

- "",

- kScriptFeedTitle,

- expected_feed_title));

+ ASSERT_TRUE(ValidatePageElement(

+ tab, std::string(), kScriptFeedTitle, expected_feed_title));

ASSERT_TRUE(ValidatePageElement(tab,

"//html/body/div/iframe[1]",

kScriptAnchor,