ipc/ipc_channel_factory.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_channel_factory.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ipc/ipc_channel_factory.cc

diff --git a/ipc/ipc_channel_factory.cc b/ipc/ipc_channel_factory.cc

index d35532852143de0a81146a0e593c32a463ddf98b..3d5c86680bf245dd9ae0b0bb11070489670e6906 100644

--- a/ipc/ipc_channel_factory.cc

+++ b/ipc/ipc_channel_factory.cc

@@ -64,7 +64,8 @@ void ChannelFactory::OnFileCanReadWithoutBlocking(int fd) {

if (!IsPeerAuthorized(new_fd))

return;

- ChannelHandle handle("", base::FileDescriptor(*scoped_fd.release(), true));

+ ChannelHandle handle(std::string(),

+ base::FileDescriptor(*scoped_fd.release(), true));

delegate_->OnClientConnected(handle);

}