sync/internal_api/public/base/model_type_invalidation_map_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/base/model_type_invalidation_map_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/internal_api/public/base/model_type_invalidation_map_unittest.cc

diff --git a/sync/internal_api/public/base/model_type_invalidation_map_unittest.cc b/sync/internal_api/public/base/model_type_invalidation_map_unittest.cc

index f05147931c647a8ad7652b4ceb83d384937dcc60..772ee7eaf5b58c0e7896fffb3bc27547aac35521 100644

--- a/sync/internal_api/public/base/model_type_invalidation_map_unittest.cc

+++ b/sync/internal_api/public/base/model_type_invalidation_map_unittest.cc

@@ -35,7 +35,7 @@ TEST_F(ModelTypeInvalidationMapTest, TypeInvalidationMapToValue) {

scoped_ptr<DictionaryValue> value(ModelTypeInvalidationMapToValue(states));

EXPECT_EQ(2u, value->size());

ExpectDictStringValue(states[BOOKMARKS].payload, *value, "Bookmarks");

- ExpectDictStringValue("", *value, "Apps");

+ ExpectDictStringValue(std::string(), *value, "Apps");

EXPECT_FALSE(value->HasKey("Preferences"));

}

« base/nix/mime_util_xdg.cc ('K') | « sync/engine/syncer_util.cc ('k') | sync/internal_api/public/base/ordinal_unittest.cc » ('j') | no next file with comments »