net/websockets/websocket_net_log_params_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/websockets/websocket_net_log_params_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/websockets/websocket_net_log_params_unittest.cc

diff --git a/net/websockets/websocket_net_log_params_unittest.cc b/net/websockets/websocket_net_log_params_unittest.cc

index e3c92a9cfe1295d032fcea60fbc3b5659b7e09df..0519390f17002ab9159ba17f2a903c8f8f39417b 100644

--- a/net/websockets/websocket_net_log_params_unittest.cc

+++ b/net/websockets/websocket_net_log_params_unittest.cc

@@ -21,7 +21,7 @@ TEST(NetLogWebSocketHandshakeParameterTest, ToValue) {

list->Append(new StringValue("Upgrade: WebSocket"));

list->Append(new StringValue("Sec-WebSocket-Key1: 4 @1 46546xW%0l 1 5"));

list->Append(new StringValue("Origin: http://example.com"));

- list->Append(new StringValue(""));

+ list->Append(new StringValue(std::string()));

list->Append(new StringValue("\\x00\\x01\\x0a\\x0d\\xff\\xfe\\x0d\\x0a"));

DictionaryValue expected;