crypto/ec_private_key_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: crypto/ec_private_key_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: crypto/ec_private_key_unittest.cc

diff --git a/crypto/ec_private_key_unittest.cc b/crypto/ec_private_key_unittest.cc

index a052a9a6d4817263fb5307f9d62ac74956573c81..8e39cebbd4afc2de73dc2eb0ec62a08667606397 100644

--- a/crypto/ec_private_key_unittest.cc

+++ b/crypto/ec_private_key_unittest.cc

@@ -23,7 +23,7 @@ TEST(ECPrivateKeyUnitTest, OpenSSLStub) {

// back the same exact public key, and the private key should have the same

// value and elliptic curve params.

TEST(ECPrivateKeyUnitTest, InitRandomTest) {

- const std::string password1 = "";

+ const std::string password1 = std::string();

const std::string password2 = "test";

scoped_ptr<crypto::ECPrivateKey> keypair1(

@@ -86,7 +86,7 @@ TEST(ECPrivateKeyUnitTest, InitRandomTest) {

}

TEST(ECPrivateKeyUnitTest, BadPasswordTest) {

- const std::string password1 = "";

+ const std::string password1 = std::string();

const std::string password2 = "test";

scoped_ptr<crypto::ECPrivateKey> keypair1(