content/browser/devtools/renderer_overrides_handler.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/renderer_overrides_handler.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/renderer_overrides_handler.cc

diff --git a/content/browser/devtools/renderer_overrides_handler.cc b/content/browser/devtools/renderer_overrides_handler.cc

index 94395d1ed83fb6cd247b6e8d2196a46bdbe91f7e..f7db2e89e9528bb567d4a03695aa750821d32f52 100644

--- a/content/browser/devtools/renderer_overrides_handler.cc

+++ b/content/browser/devtools/renderer_overrides_handler.cc

@@ -145,8 +145,8 @@ RendererOverridesHandler::PageNavigate(

if (host) {

WebContents* web_contents = host->GetDelegate()->GetAsWebContents();

if (web_contents) {

- web_contents->GetController().LoadURL(

- gurl, Referrer(), PAGE_TRANSITION_TYPED, "");

+ web_contents->GetController()

+ .LoadURL(gurl, Referrer(), PAGE_TRANSITION_TYPED, std::string());

return command->SuccessResponse(new base::DictionaryValue());

}