base/test/trace_event_analyzer.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/test/trace_event_analyzer.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/test/trace_event_analyzer.cc

diff --git a/base/test/trace_event_analyzer.cc b/base/test/trace_event_analyzer.cc

index 431945b663459ef21f42ae1560d087d7b169e031..8457ce97cf63ac318b7eb50b98aa7a1e1aa2d954 100644

--- a/base/test/trace_event_analyzer.cc

+++ b/base/test/trace_event_analyzer.cc

@@ -140,7 +140,7 @@ std::string TraceEvent::GetKnownArgAsString(const std::string& name) const {

if (GetArgAsString(name, &arg_string))

return arg_string;

NOTREACHED();

- return "";

+ return std::string();

}

double TraceEvent::GetKnownArgAsDouble(const std::string& name) const {