base/values_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/values_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/values_unittest.cc

diff --git a/base/values_unittest.cc b/base/values_unittest.cc

index 98bc73c9a1b7ee50613ec562cd233a3eca23cccf..bad83fa2fa8f8aad6d0b75627b62398d4357babb 100644

--- a/base/values_unittest.cc

+++ b/base/values_unittest.cc

@@ -599,7 +599,7 @@ TEST(ValuesTest, RemoveEmptyChildren) {

// Make sure we don't prune too much.

root->SetBoolean("bool", true);

root->Set("empty_dict", new DictionaryValue);

- root->SetString("empty_string", "");

+ root->SetString("empty_string", std::string());

root.reset(root->DeepCopyWithoutEmptyChildren());

EXPECT_EQ(2U, root->size());