chrome/browser/content_settings/content_settings_utils_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/content_settings_utils_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/content_settings/content_settings_utils_unittest.cc

diff --git a/chrome/browser/content_settings/content_settings_utils_unittest.cc b/chrome/browser/content_settings/content_settings_utils_unittest.cc

index 69f88c1c78c28543bfe6eae1e8bf97272f4bbf6a..d5eeecac3056cb147b130975715f7d3ba623c1a0 100644

--- a/chrome/browser/content_settings/content_settings_utils_unittest.cc

+++ b/chrome/browser/content_settings/content_settings_utils_unittest.cc

@@ -11,7 +11,7 @@

TEST(ContentSettingsUtilsTest, ParsePatternString) {

content_settings::PatternPair pattern_pair;

- pattern_pair = content_settings::ParsePatternString("");

+ pattern_pair = content_settings::ParsePatternString(std::string());

EXPECT_FALSE(pattern_pair.first.IsValid());

EXPECT_FALSE(pattern_pair.second.IsValid());