base/strings/string_split.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/strings/string_split.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/strings/string_split.cc

diff --git a/base/strings/string_split.cc b/base/strings/string_split.cc

index f5f19e98077b0cee02c44a731910a667c353a5a7..819fdbadcad5682618399f2ddaf1609b17dea7db 100644

--- a/base/strings/string_split.cc

+++ b/base/strings/string_split.cc

@@ -107,7 +107,8 @@ bool SplitStringIntoKeyValuePairs(

success = false;

}

DCHECK_LE(value.size(), 1U);

- kv_pairs->push_back(make_pair(key, value.empty()? "" : value[0]));

+ kv_pairs->push_back(

+ make_pair(key, value.empty() ? std::string() : value[0]));

}

return success;

}