Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1355)

Unified Diff: chrome/browser/extensions/activity_log.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log.cc
diff --git a/chrome/browser/extensions/activity_log.cc b/chrome/browser/extensions/activity_log.cc
index 34f820b1f3abf2feb0a83a5c2ad3ee3aee4490c5..0b4a7dbdfff11b47078739038fb0c8539ef624a6 100644
--- a/chrome/browser/extensions/activity_log.cc
+++ b/chrome/browser/extensions/activity_log.cc
@@ -27,7 +27,7 @@ namespace {
// Concatenate arguments.
std::string MakeArgList(const ListValue* args) {
- std::string call_signature = "";
+ std::string call_signature = std::string();
ListValue::const_iterator it = args->begin();
for (; it != args->end(); ++it) {
std::string arg;
@@ -395,9 +395,10 @@ void ActivityLog::OnScriptsExecuted(
// of content scripts will be empty. We don't want to log it because
// the call to tabs.executeScript will have already been logged anyway.
if (!it->second.empty()) {
- std::string ext_scripts_str = "";
+ std::string ext_scripts_str = std::string();
for (std::set<std::string>::const_iterator it2 = it->second.begin();
- it2 != it->second.end(); ++it2) {
+ it2 != it->second.end();
+ ++it2) {
ext_scripts_str += *it2;
ext_scripts_str += " ";
}
@@ -406,9 +407,9 @@ void ActivityLog::OnScriptsExecuted(
LogDOMActionInternal(extension,
on_url,
web_contents->GetTitle(),
- "", // no api call here
+ std::string(), // no api call here
script_names.get(),
- "", // no extras either
+ std::string(), // no extras either
DOMAction::INSERTED);
}
}

Powered by Google App Engine
This is Rietveld 408576698