chrome/browser/about_flags_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/about_flags_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/about_flags_unittest.cc

diff --git a/chrome/browser/about_flags_unittest.cc b/chrome/browser/about_flags_unittest.cc

index 4720ce6619bcdeee0c3080255f5b5818cdd3d366..1f6ef0458f8ab6efefc65909415beb52c699db2c 100644

--- a/chrome/browser/about_flags_unittest.cc

+++ b/chrome/browser/about_flags_unittest.cc

@@ -285,7 +285,7 @@ TEST_F(AboutFlagsTest, CheckValues) {

// Convert the flags to switches.

ConvertFlagsToSwitches(&prefs_, &command_line);

EXPECT_TRUE(command_line.HasSwitch(kSwitch1));

- EXPECT_EQ(std::string(""), command_line.GetSwitchValueASCII(kSwitch1));

+ EXPECT_EQ(std::string(), command_line.GetSwitchValueASCII(kSwitch1));

EXPECT_TRUE(command_line.HasSwitch(kSwitch2));

EXPECT_EQ(std::string(kValueForSwitch2),

command_line.GetSwitchValueASCII(kSwitch2));