build/java_apk.gypi - Issue 1314493010: Never run errorprone on non-Chromium code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/java_apk.gypi

Issue 1314493010: Never run errorprone on non-Chromium code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/java_apk.gypi

diff --git a/build/java_apk.gypi b/build/java_apk.gypi

index 6dbb85876aae863af245d77d46bae8a3f9e1ab50..1caaf90f3a991dd4ae73f59cd4b8eac7ea994439 100644

--- a/build/java_apk.gypi

+++ b/build/java_apk.gypi

@@ -213,7 +213,12 @@

'native_lib_placeholder_stamp': '<(apk_package_native_libs_dir)/<(android_app_abi)/native_lib_placeholder.stamp',

'native_lib_placeholders': [],

'main_apk_name': '<(apk_name)',

- 'enable_errorprone%': '0',

+ 'conditions': [

+ ['chromium_code == 0', {

+ 'enable_errorprone': 0,

+ }],

+ ],

+ 'enable_errorprone%': 0,

'errorprone_exe_path': '<(PRODUCT_DIR)/bin.java/chromium_errorprone',

# Pass the jar path to the apk's "fake" jar target. This would be better as

« build/host_jar.gypi ('K') | « build/java.gypi ('k') | no next file » | no next file with comments »