Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/host_jar.gypi

Issue 1314493010: Never run errorprone on non-Chromium code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/android/internal_rules.gni ('K') | « build/config/android/internal_rules.gni ('k') | build/java.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/host_jar.gypi
diff --git a/build/host_jar.gypi b/build/host_jar.gypi
index a47f6bbdd99dd215b5375a9c6dcc47437522e696..40778064590e41ba203e2dbedb597e380bfa239a 100644
--- a/build/host_jar.gypi
+++ b/build/host_jar.gypi
@@ -53,7 +53,12 @@
'jar_path': '<(jar_dir)/<(jar_name)',
'main_class%': '',
'stamp': '<(intermediate_dir)/jar.stamp',
- 'enable_errorprone%': '0',
+ 'conditions': [
+ ['chromium_code == 0', {
+ 'enable_errorprone': 0,
jbudorick 2015/08/26 19:44:25 Really? This works?
mikecase (-- gone --) 2015/08/26 20:16:51 Just double checked. This will make enable_errorpr
+ }],
+ ],
+ 'enable_errorprone%': 0,
'errorprone_exe_path': '<(PRODUCT_DIR)/bin.java/chromium_errorprone',
},
'all_dependent_settings': {
« build/config/android/internal_rules.gni ('K') | « build/config/android/internal_rules.gni ('k') | build/java.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698