build/config/android/internal_rules.gni - Issue 1314493010: Never run errorprone on non-Chromium code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/android/internal_rules.gni

Issue 1314493010: Never run errorprone on non-Chromium code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/android/internal_rules.gni

diff --git a/build/config/android/internal_rules.gni b/build/config/android/internal_rules.gni

index 287a0066fba3b8270d4ad585890bfb451891a87c..707442080cd5547a8c5062c6239d4c50794e3ab6 100644

--- a/build/config/android/internal_rules.gni

+++ b/build/config/android/internal_rules.gni

@@ -901,7 +901,9 @@ template("compile_java") {

}

_enable_errorprone = use_errorprone_java_compiler

- if (defined(invoker.enable_errorprone)) {

+ if (!_chromium_code) {

jbudorick 2015/08/27 16:53:49 GN is so much more sane.

+ _enable_errorprone = false

+ } else if (defined(invoker.enable_errorprone)) {

_enable_errorprone = invoker.enable_errorprone

}

« no previous file with comments | « no previous file | build/host_jar.gypi » ('j') | build/host_jar.gypi » ('J')