Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1314493008: Add a PermissionDeniedError, update Push API public API (Closed)

Created:
5 years, 3 months ago by Peter Beverloo
Modified:
5 years, 3 months ago
CC:
blink-reviews, mvanouwerkerk+watch_chromium.org, blink-reviews-dom_chromium.org, vivekg_samsung, johnme+watch_chromium.org, sof, eae+blinkwatch, vivekg, dglazkov+blink, blink-reviews-bindings_chromium.org, peter+watch_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add a PermissionDeniedError, update Push API public API The Push API defines that the subscription promise should be rejected with a DOMException named PermissionDeniedError when no permission has been granted. https://w3c.github.io/push-api/#widl-PushManager-subscribe-Promise-PushSubscription--PushSubscriptionOptions-options While this error code is not formally included in the registry, IDL is not staffed, and guidance from the spec bug is to just start using the new name. https://www.w3.org/Bugs/Public/show_bug.cgi?id=23033 This CL is part of a three-sided patch: [1] This CL. [2] https://codereview.chromium.org/1316973002/ [3] https://codereview.chromium.org/1313493003/ BUG=522206 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201400

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M LayoutTests/http/tests/push_messaging/subscribe-failure-permission-denied-in-document.html View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/core/v8/PrivateScriptRunner.js View 1 chunk +3 lines, -0 lines 2 comments Download
M Source/core/dom/DOMException.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/dom/ExceptionCode.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/push_messaging/PushError.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M public/platform/modules/push_messaging/WebPushError.h View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
Peter Beverloo
+mvanouwerkerk, before I poke the DOM team
5 years, 3 months ago (2015-08-26 14:37:39 UTC) #2
johnme
lgtm with nits https://codereview.chromium.org/1314493008/diff/1/Source/bindings/core/v8/PrivateScriptRunner.js File Source/bindings/core/v8/PrivateScriptRunner.js (right): https://codereview.chromium.org/1314493008/diff/1/Source/bindings/core/v8/PrivateScriptRunner.js#newcode64 Source/bindings/core/v8/PrivateScriptRunner.js:64: // Push API Nit: Shouldn't this ...
5 years, 3 months ago (2015-08-27 16:09:09 UTC) #4
Peter Beverloo
+haraken, PTAL :) https://codereview.chromium.org/1314493008/diff/1/Source/bindings/core/v8/PrivateScriptRunner.js File Source/bindings/core/v8/PrivateScriptRunner.js (right): https://codereview.chromium.org/1314493008/diff/1/Source/bindings/core/v8/PrivateScriptRunner.js#newcode64 Source/bindings/core/v8/PrivateScriptRunner.js:64: // Push API On 2015/08/27 16:09:08, ...
5 years, 3 months ago (2015-08-27 16:24:31 UTC) #6
haraken
LGTM I agree that we can update the comment when we actually start using the ...
5 years, 3 months ago (2015-08-27 23:51:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314493008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314493008/1
5 years, 3 months ago (2015-08-28 12:41:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201400
5 years, 3 months ago (2015-08-28 13:47:16 UTC) #10
Michael van Ouwerkerk
5 years, 3 months ago (2015-09-01 10:01:45 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698