Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1313493003: Re-enable a push subscription-without-permission layout test. (Closed)

Created:
5 years, 3 months ago by Peter Beverloo
Modified:
5 years, 3 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Re-enable a push subscription-without-permission layout test. Now that the appropriate DOMException is being thrown, we can test for that. This CL is part of a three-sided patch: [1] https://codereview.chromium.org/1314493008/ [2] https://codereview.chromium.org/1316973002/ [3] This CL. BUG=522206 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201556

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M LayoutTests/http/tests/push_messaging/subscribe-failure-permission-denied-in-document.html View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
Peter Beverloo
PTAL
5 years, 3 months ago (2015-08-26 14:37:48 UTC) #2
johnme
lgtm
5 years, 3 months ago (2015-08-27 16:11:20 UTC) #4
Michael van Ouwerkerk
lgtm
5 years, 3 months ago (2015-09-01 10:01:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313493003/1
5 years, 3 months ago (2015-09-01 13:38:00 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 14:19:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201556

Powered by Google App Engine
This is Rietveld 408576698