Vector ICs: Stop iterating the heap to clear keyed store ics.

Vector ICs: Stop iterating the heap to clear keyed store ics.

When vector based stores are on, we don't need to do this anymore.

BUG=

Committed: https://crrev.com/7db48046ea7c324efe8fd65512b69e43b1f39ebe
Cr-Commit-Position: refs/heads/master@{#30401}

[mvstanton, 2015-08-26 09:57:10]

mvstanton@chromium.org changed reviewers:
+ hpayer@chromium.org

[mvstanton, 2015-08-26 09:57:11]

Hi Hannes, here is the issue we discussed.

[mvstanton, 2015-08-26 10:18:51]

https://codereview.chromium.org/1314433004/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1314433004/diff/1/src/heap/heap.h#newcode857
src/heap/heap.h:857: void ClearAllKeyedStoreICs();
I did the rename here to narrow the perceived functionality. In general this is
a lame thing to do, and I don't want a new customer to appear passing some other
IC kind.

[Hannes Payer (out of office), 2015-08-26 21:46:33]

https://codereview.chromium.org/1314433004/diff/1/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/1314433004/diff/1/src/heap/heap.cc#newcode480
src/heap/heap.cc:480: void Heap::ClearAllKeyedStoreICs() {
I do not like that heap owns this method. It has no heap dependencies. It could
be a static in KeyedStoreIC.

https://codereview.chromium.org/1314433004/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1314433004/diff/1/src/heap/heap.h#newcode857
src/heap/heap.h:857: void ClearAllKeyedStoreICs();
On 2015/08/26 10:18:50, mvstanton wrote:
> I did the rename here to narrow the perceived functionality. In general this
is
> a lame thing to do, and I don't want a new customer to appear passing some
other
> IC kind.

Acknowledged.

[mvstanton, 2015-08-27 08:17:33]

Hi Hannes, thanks for the review, here are changes.
--Michael

https://codereview.chromium.org/1314433004/diff/1/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/1314433004/diff/1/src/heap/heap.cc#newcode480
src/heap/heap.cc:480: void Heap::ClearAllKeyedStoreICs() {
On 2015/08/26 21:46:33, Hannes Payer wrote:
> I do not like that heap owns this method. It has no heap dependencies. It
could
> be a static in KeyedStoreIC.

Okay, I've taken the new code and moved it. The call to code_space() in the old
code is a dependency. That branch will disappear when FLAG_vector_stores is
turned on, then discarded.

Also, I put the new code as a static in TypeFeedbackVector, because 1) in the
vector-based world, that is a good home, and 2) I felt much better about
including type-feedback-vector.h in heap.cc, than about including ic.h! The
former is at least a heap object, the latter is a whole byzantine world that
shouldn't be cluttering up heap.cc. :)

[Hannes Payer (out of office), 2015-08-27 08:31:44]

lgtm

[Hannes Payer (out of office), 2015-08-27 08:31:47]

The CQ bit was checked by hpayer@chromium.org

[commit-bot: I haz the power, 2015-08-27 08:31:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314433004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314433004/20001

[commit-bot: I haz the power, 2015-08-27 08:52:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-27 08:52:24]

Patchset 2 (id:??) landed as
https://crrev.com/7db48046ea7c324efe8fd65512b69e43b1f39ebe
Cr-Commit-Position: refs/heads/master@{#30401}