Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: src/objects-printer.cc

Issue 1314433004: Vector ICs: Stop iterating the heap to clear keyed store ics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Code review. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | src/type-feedback-vector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-printer.cc
diff --git a/src/objects-printer.cc b/src/objects-printer.cc
index de8aa444d45d7eeecf0c8ec843a2534abd9b9f56..538864418776ad8492e755f38dd728e86c6b6f93 100644
--- a/src/objects-printer.cc
+++ b/src/objects-printer.cc
@@ -572,10 +572,17 @@ void TypeFeedbackVector::TypeFeedbackVectorPrint(std::ostream& os) { // NOLINT
KeyedLoadICNexus nexus(this, slot);
os << " KEYED_LOAD_IC "
<< Code::ICState2String(nexus.StateFromFeedback());
- } else {
- DCHECK(kind == Code::CALL_IC);
+ } else if (kind == Code::CALL_IC) {
CallICNexus nexus(this, slot);
os << " CALL_IC " << Code::ICState2String(nexus.StateFromFeedback());
+ } else if (kind == Code::STORE_IC) {
+ StoreICNexus nexus(this, slot);
+ os << " STORE_IC " << Code::ICState2String(nexus.StateFromFeedback());
+ } else {
+ DCHECK(kind == Code::KEYED_STORE_IC);
+ KeyedStoreICNexus nexus(this, slot);
+ os << " KEYED_STORE_IC "
+ << Code::ICState2String(nexus.StateFromFeedback());
}
os << "\n [" << GetIndex(slot) << "]: " << Brief(Get(slot));
« no previous file with comments | « src/objects.cc ('k') | src/type-feedback-vector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698