make sure cflags is forwarded in the ios_app executable template

Make sure cflags is forwarded in the ios_app executable template.

R=brettw@chromium.org, kjellander@chromium.org

Committed: https://crrev.com/4bcc95b28ee924fa3ac5b488a9c2a954336533b5
Cr-Commit-Position: refs/heads/master@{#348264}

[kjellander_chromium, 2015-09-09 20:20:34]

lgtm, with this I'm able to run GN for https://codereview.webrtc.org/1309663007/
without any error.

Thanks for the quick fix.

[brettw, 2015-09-09 20:28:58]

What about all the other flags? The set of things getting forwarded through the
chain of templates should match up.

[Dirk Pranke, 2015-09-09 20:38:03]

On 2015/09/09 20:28:58, brettw wrote:
> What about all the other flags? The set of things getting forwarded through
the
> chain of templates should match up.

I will double-check.

[Dirk Pranke, 2015-09-09 21:04:44]

On 2015/09/09 20:38:03, Dirk Pranke wrote:
> On 2015/09/09 20:28:58, brettw wrote:
> > What about all the other flags? The set of things getting forwarded through
> the
> > chain of templates should match up.
> 
> I will double-check.

Okay, I forwarded a bunch more, but I'm not 100% comfortable with how this is
working out. It seems like we have to forward a bunch of flags that can't be
used?

For example, the test() template explicitly moves sources into a new __sources
target that the executable depends on. So, the executable doesn't have any
sources, and hence cflags won't actually be used. So am I just forwarding these
things to shut up GN?

[brettw, 2015-09-09 21:15:19]

- The ios_app template should forward basically everything that could
conceivably apply to the underlying executable target. It's logically a wrapper
around an executable, so should behave line an executable as much as possible.

- The __sources template in the test template seems to do nothing. Unless you
can dig up a good reason for it to exist, we should just fold these sources into
the ios_app call. Generating these extra targets just makes this more
complicated.

- If we needed the __sources template and continued to do no sources on the
ios_app invocation, then the test template should forward the cflags, defined,
etc. on the source set and not on the ios_app.

[Dirk Pranke, 2015-09-09 21:18:47]

On 2015/09/09 21:15:19, brettw wrote:
> - The ios_app template should forward basically everything that could
> conceivably apply to the underlying executable target. It's logically a
wrapper
> around an executable, so should behave line an executable as much as possible.
> 
> - The __sources template in the test template seems to do nothing. Unless you
> can dig up a good reason for it to exist, we should just fold these sources
into
> the ios_app call. Generating these extra targets just makes this more
> complicated.
> 
> - If we needed the __sources template and continued to do no sources on the
> ios_app invocation, then the test template should forward the cflags, defined,
> etc. on the source set and not on the ios_app.

That seems reasonable.

However, it seems like the test() template is forwarding a bunch of variables
that can't make sense for executables or apk's, e.g., public, public_deps,
forward_dependent_configs_from, etc. Should we delete those?

[brettw, 2015-09-09 21:20:48]

Since executable supports these, I think we should forward them.

[Dirk Pranke, 2015-09-09 22:39:45]

remove __sources target from test() template, forward more vars

[Dirk Pranke, 2015-09-09 22:52:37]

Okay, reworked. Please take another look?

[brettw, 2015-09-10 04:41:16]

lgtm

[Dirk Pranke, 2015-09-10 22:08:06]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2015-09-10 22:08:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@chromium.org
Link to the patchset: https://codereview.chromium.org/1314413006/#ps40001
(title: "remove __sources target from test() template, forward more vars")

[commit-bot: I haz the power, 2015-09-10 22:08:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314413006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314413006/40001

[commit-bot: I haz the power, 2015-09-10 22:37:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-10 22:38:13]

Patchset 3 (id:??) landed as
https://crrev.com/4bcc95b28ee924fa3ac5b488a9c2a954336533b5
Cr-Commit-Position: refs/heads/master@{#348264}

[commit-bot: I haz the power, 2015-09-23 12:15:24]

Patchset 3 (id:??) landed as
https://crrev.com/4bcc95b28ee924fa3ac5b488a9c2a954336533b5
Cr-Commit-Position: refs/heads/master@{#348264}