Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1311453010: Fix gn_all, net_unittests build on GN ios. (Closed)

Created:
5 years, 3 months ago by Dirk Pranke
Modified:
5 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, cbentzel+watch_chromium.org, sherouk, sdefresne
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_ios_app
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gn_all, net_unittests build on GN ios. Stray references to v8 components had gotten in. R=brettw@chromium.org Committed: https://crrev.com/d2fb5223985f7a03f41f4d79481207381999a8f0 Cr-Commit-Position: refs/heads/master@{#348265}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M BUILD.gn View 1 chunk +7 lines, -3 lines 0 comments Download
M net/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1314413006 Patch 40001

Messages

Total messages: 7 (1 generated)
Dirk Pranke
5 years, 3 months ago (2015-09-09 22:52:11 UTC) #1
brettw
lgtm
5 years, 3 months ago (2015-09-10 04:41:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311453010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311453010/1
5 years, 3 months ago (2015-09-10 22:08:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-10 22:39:12 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d2fb5223985f7a03f41f4d79481207381999a8f0 Cr-Commit-Position: refs/heads/master@{#348265}
5 years, 3 months ago (2015-09-10 22:39:44 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:15:26 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d2fb5223985f7a03f41f4d79481207381999a8f0
Cr-Commit-Position: refs/heads/master@{#348265}

Powered by Google App Engine
This is Rietveld 408576698