Cast ChromeShell into the fiery pit of Mount Doom.

Cast ChromeShell into the fiery pit of Mount Doom.

This deletes the no-longer-used ChromeShell. Its raison d'être has been
supplanted by ChromePublic (the chrome_public_apk build target).
Goodbye, ChromeShell!

BUG=510220
Committed: https://crrev.com/44ce026f8450c71f6592beb02c7db825c1c4e82c
Cr-Commit-Position: refs/heads/master@{#347454}

[newt (away), 2015-09-03 00:18:59]

newt@chromium.org changed reviewers:
+ tedchoc@chromium.org

[newt (away), 2015-09-03 00:18:59]

PTAL

[newt (away), 2015-09-03 00:21:12]

The CQ bit was checked by newt@chromium.org to run a CQ dry run

[jbudorick, 2015-09-03 00:27:44]

jbudorick@chromium.org changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2015-09-03 00:27:45]

swooping in from the watchlist to say lgtm

:D

[Ted C, 2015-09-03 00:29:57]

https://codereview.chromium.org/1314413004/diff/1/chrome/chrome_android.gypi
File chrome/chrome_android.gypi (right):

https://codereview.chromium.org/1314413004/diff/1/chrome/chrome_android.gypi#...
chrome/chrome_android.gypi:14: 'package_name': 'chrome_yay',
huh?

[commit-bot: I haz the power, 2015-09-03 00:31:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314413004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314413004/1

[Yaron, 2015-09-03 01:06:17]

On 2015/09/03 00:31:35, commit-bot: I haz the power wrote:
> Dry run: CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1314413004/1
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1314413004/1

w00t!

[newt (away), 2015-09-03 01:09:09]

https://codereview.chromium.org/1314413004/diff/1/chrome/chrome_android.gypi
File chrome/chrome_android.gypi (right):

https://codereview.chromium.org/1314413004/diff/1/chrome/chrome_android.gypi#...
chrome/chrome_android.gypi:14: 'package_name': 'chrome_yay',
On 2015/09/03 00:29:57, Ted C wrote:
> huh?

Whoops: debugging code. Removed this, and fixed some super weirdness with
chrome_android_paks.gypi.

https://codereview.chromium.org/1314413004/diff/20001/chrome/chrome.gyp
File chrome/chrome.gyp (right):

https://codereview.chromium.org/1314413004/diff/20001/chrome/chrome.gyp#newco...
chrome/chrome.gyp:670: 'package_name': 'chrome_locale_paks',
The poorly named package_name variable needs to be defined here because we're
including chrome_android_paks.gypi below, which copies pak files into
out/Debug/assets/<(package_name)/.

Previously, package_name happened to be defined by (un?)lucky coincidence as
"chrome_shell_apk", which makes no sense. How? Well, chrome.gyp includes
chrome_android.gypi which used to include chrome_shell.gypi which defined
package_name as "chrome_shell_apk". How's that for unintended consequences of
gypi inclusion and global variable propagation?

[newt (away), 2015-09-03 01:10:24]

newt@chromium.org changed reviewers:
+ maruel@chromium.org, thakis@chromium.org

[newt (away), 2015-09-03 01:10:25]

+maruel for deleting chrome/chrome_shell_test_apk.isolate
+thakis for chrome.gyp

[newt (away), 2015-09-03 01:11:27]

On 2015/09/03 01:06:17, Yaron wrote:
> On 2015/09/03 00:31:35, commit-bot: I haz the power wrote:
> > Dry run: CQ is trying da patch. Follow status at
> >  https://chromium-cq-status.appspot.com/patch-status/1314413004/1
> > View timeline at
> >  https://chromium-cq-status.appspot.com/patch-timeline/1314413004/1
> 
> w00t!

:D

[M-A Ruel, 2015-09-03 01:18:41]

On 2015/09/03 01:10:25, newt wrote:
> +maruel for deleting chrome/chrome_shell_test_apk.isolate

You don't really need my lgtm to delete a .isolate, please delete at will.

[newt (away), 2015-09-03 01:38:55]

The CQ bit was checked by newt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-03 01:39:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314413004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314413004/20001

[Nico, 2015-09-03 01:49:01]

lgtm :-)

https://codereview.chromium.org/1314413004/diff/20001/chrome/chrome.gyp
File chrome/chrome.gyp (right):

https://codereview.chromium.org/1314413004/diff/20001/chrome/chrome.gyp#newco...
chrome/chrome.gyp:670: 'package_name': 'chrome_locale_paks',
On 2015/09/03 01:09:09, newt wrote:
> The poorly named package_name variable needs to be defined here because we're
> including chrome_android_paks.gypi below, which copies pak files into
> out/Debug/assets/<(package_name)/.
> 
> Previously, package_name happened to be defined by (un?)lucky coincidence as
> "chrome_shell_apk", which makes no sense. How? Well, chrome.gyp includes
> chrome_android.gypi which used to include chrome_shell.gypi which defined
> package_name as "chrome_shell_apk". How's that for unintended consequences of
> gypi inclusion and global variable propagation?

Thanks for this comment!

[commit-bot: I haz the power, 2015-09-03 03:03:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-03 03:03:28]

Dry run: This issue passed the CQ dry run.

[Ted C, 2015-09-03 04:04:47]

lgtm

[newt (away), 2015-09-04 17:10:18]

The CQ bit was checked by newt@chromium.org

[newt (away), 2015-09-04 17:10:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org, tedchoc@chromium.org, thakis@chromium.org,
maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/1314413004/#ps40001
(title: "rebased")

[commit-bot: I haz the power, 2015-09-04 17:10:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314413004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314413004/40001

[commit-bot: I haz the power, 2015-09-04 18:46:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-04 18:46:58]

Patchset 3 (id:??) landed as
https://crrev.com/44ce026f8450c71f6592beb02c7db825c1c4e82c
Cr-Commit-Position: refs/heads/master@{#347454}