Cast ChromeShell into the fiery pit of Mount Doom.

chrome/chrome.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 {
   'variables': {
     'chromium_code': 1,
 
     # Define the common dependencies that contain all the actual
     # Chromium functionality.  This list gets pulled in below by
     # the link of the actual chrome (or chromium) executable on
@@ skipping 649 matching lines @@
           },
           'includes': [
             '../build/java_strings_grd.gypi',
           ],
         },
         {
           # GN: //chrome/android:chrome_locale_paks
           'target_name': 'chrome_locale_paks',
           'type': 'none',
           'variables': {
+            'package_name': 'chrome_locale_paks',

[newt (away), 2015/09/03 01:09:09]

The poorly named package_name variable needs to be defined here because we're
including chrome_android_paks.gypi below, which copies pak files into
out/Debug/assets/<(package_name)/.

Previously, package_name happened to be defined by (un?)lucky coincidence as
"chrome_shell_apk", which makes no sense. How? Well, chrome.gyp includes
chrome_android.gypi which used to include chrome_shell.gypi which defined
package_name as "chrome_shell_apk". How's that for unintended consequences of
gypi inclusion and global variable propagation?

[Nico, 2015/09/03 01:49:00]

Thanks for this comment!

             'locale_pak_files': [ '<@(chrome_android_pak_locale_resources)' ],
           },
           'includes': [
             'chrome_android_paks.gypi',
             '../build/android/locale_pak_resources.gypi',
           ],
         },
         {
           # GN: //chrome:content_setting_javagen
           'target_name': 'content_setting_java',
@@ skipping 155 matching lines @@
                   '<(DEPTH)/third_party/kasko'
                 ],
               },
             },
           },
         },
       ],
     }],
   ],  # 'conditions'
 }