Source/core/css/CSSCounterValue.h - Issue 1314353002: Inline CSSCounterValue::listStyle()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSCounterValue.h

Issue 1314353002: Inline CSSCounterValue::listStyle() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@clean_up_get_string_value

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSCounterValue.h

diff --git a/Source/core/css/CSSCounterValue.h b/Source/core/css/CSSCounterValue.h

index b7eb49ffbd7d3092bc1cffe557d8d566a18f7be0..838640ef4fa2c90541d471adaf0f0810a3636f88 100644

--- a/Source/core/css/CSSCounterValue.h

+++ b/Source/core/css/CSSCounterValue.h

@@ -35,11 +35,9 @@ public:

}

String identifier() const { return m_identifier->getStringValue(); }

- String listStyle() const { return m_listStyle->cssText(); }

+ CSSValueID listStyle() const { return m_listStyle->getValueID(); }

String separator() const { return m_separator->getStringValue(); }

- CSSValueID listStyleIdent() const { return m_listStyle->getValueID(); }

bool equals(const CSSCounterValue& other) const

{

return identifier() == other.identifier()

« no previous file with comments | « no previous file | Source/core/css/CSSCounterValue.cpp » ('j') | Source/core/css/CSSCounterValue.cpp » ('J')