Source/core/css/CSSCounterValue.cpp - Issue 1314353002: Inline CSSCounterValue::listStyle()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSCounterValue.cpp

Issue 1314353002: Inline CSSCounterValue::listStyle() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@clean_up_get_string_value

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSCounterValue.cpp

diff --git a/Source/core/css/CSSCounterValue.cpp b/Source/core/css/CSSCounterValue.cpp

index 6a1f0698768175dd1086da613b091acc7504ae67..7e286d1e8f944ec3a40a1bac93bf2995dd376fa4 100644

--- a/Source/core/css/CSSCounterValue.cpp

+++ b/Source/core/css/CSSCounterValue.cpp

@@ -23,10 +23,10 @@ String CSSCounterValue::customCSSText() const

result.appendLiteral(", ");

result.append(serializeString(separator()));

}

- bool isDefaultListStyle = listStyleIdent() == CSSValueDecimal;

- if (!listStyle().isEmpty() && !isDefaultListStyle) {

+ bool isDefaultListStyle = listStyle() == CSSValueDecimal;

+ if (!m_listStyle->cssText().isEmpty() && !isDefaultListStyle) {

Timothy Loh 2015/08/27 07:18:41 it's never empty :S

sashab 2015/08/28 00:50:30 You are correct!

result.appendLiteral(", ");

- result.append(listStyle());

+ result.append(m_listStyle->cssText());

}

result.append(')');

« no previous file with comments | « Source/core/css/CSSCounterValue.h ('k') | Source/core/css/resolver/StyleBuilderCustom.cpp » ('j') | no next file with comments »