Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1707)

Unified Diff: Source/modules/accessibility/AXLayoutObject.cpp

Issue 1314253002: Removed the requirement to call setSelection directly on the text field in order to set its selecti… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXLayoutObject.cpp
diff --git a/Source/modules/accessibility/AXLayoutObject.cpp b/Source/modules/accessibility/AXLayoutObject.cpp
index 2d4976431777b4cb7ea0fd4af4c52b03afaaccf5..8ee841a7ca03f3b7961a7204b6da929ca85eb5ef 100644
--- a/Source/modules/accessibility/AXLayoutObject.cpp
+++ b/Source/modules/accessibility/AXLayoutObject.cpp
@@ -2018,10 +2018,10 @@ void AXLayoutObject::setSelection(const AXRange& selection)
AXObject* focusObject = selection.focusObject ?
Peter Lundblad 2015/08/28 15:09:43 Perhaps the initial part of this function could be
selection.focusObject.get() : this;
- if (anchorObject == this && anchorObject == focusObject
- && layoutObject()->isTextControl()) {
+ if (anchorObject == focusObject
+ && anchorObject->layoutObject()->isTextControl()) {
HTMLTextFormControlElement* textControl = toLayoutTextControl(
- layoutObject())->textFormControlElement();
+ anchorObject->layoutObject())->textFormControlElement();
textControl->setSelectionRange(selection.anchorOffset, selection.focusOffset,
SelectionHasNoDirection, NotDispatchSelectEvent);
Peter Lundblad 2015/08/28 15:09:43 Why doesn't the direction depend on which one of t
return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698