Removed the requirement to call setSelection directly on the text field in order to set its selecti…

Source/modules/accessibility/AXLayoutObject.cpp

 /*
 * Copyright (C) 2008 Apple Inc. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 *
 * 1.  Redistributions of source code must retain the above copyright
 *     notice, this list of conditions and the following disclaimer.
 * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 1997 matching lines @@
         return;
 
     if (selection.anchorObject && !isValidSelectionBound(selection.anchorObject.get()))
         return;
 
     if (selection.focusObject && !isValidSelectionBound(selection.focusObject.get()))
         return;
 
     AXObject* anchorObject = selection.anchorObject ?
         selection.anchorObject.get() : this;
     AXObject* focusObject = selection.focusObject ?

[Peter Lundblad, 2015/08/28 15:09:43]

Perhaps the initial part of this function could be simplified if you did the
null->this assignments first and then do the rest of the checks on those
pointers. Now it looks like there is some duplication in there.

         selection.focusObject.get() : this;
 
-    if (anchorObject == this && anchorObject == focusObject
-        && layoutObject()->isTextControl()) {
+    if (anchorObject == focusObject
+        && anchorObject->layoutObject()->isTextControl()) {
         HTMLTextFormControlElement* textControl = toLayoutTextControl(
-            layoutObject())->textFormControlElement();
+            anchorObject->layoutObject())->textFormControlElement();
         textControl->setSelectionRange(selection.anchorOffset, selection.focusOffset,
             SelectionHasNoDirection, NotDispatchSelectEvent);

[Peter Lundblad, 2015/08/28 15:09:43]

Why doesn't the direction depend on which one of the start and end pint is
larger to keep the distinction between anchor and focus even for text fields?

         return;
     }
 
     Node* anchorNode = nullptr;
     while (anchorObject && !anchorNode) {
         anchorNode = anchorObject->node();
         anchorObject = anchorObject->parentObject();
     }
 
     Node* focusNode = nullptr;
@@ skipping 610 matching lines @@
         if (label && label->layoutObject()) {
             LayoutRect labelRect = axObjectCache().getOrCreate(label)->elementRect();
             result.unite(labelRect);
         }
     }
 
     return result;
 }
 
 } // namespace blink