Removed the requirement to call setSelection directly on the text field in order to set its selecti…

Removed the requirement to call setSelection directly on the text field in order to set its selection.

R=dmazzoni@chromium.org, plundblad@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201438

[Peter Lundblad, 2015-08-28 15:09:43]

https://codereview.chromium.org/1314253002/diff/1/Source/modules/accessibilit...
File Source/modules/accessibility/AXLayoutObject.cpp (right):

https://codereview.chromium.org/1314253002/diff/1/Source/modules/accessibilit...
Source/modules/accessibility/AXLayoutObject.cpp:2018: AXObject* focusObject =
selection.focusObject ?
Perhaps the initial part of this function could be simplified if you did the
null->this assignments first and then do the rest of the checks on those
pointers. Now it looks like there is some duplication in there.

https://codereview.chromium.org/1314253002/diff/1/Source/modules/accessibilit...
Source/modules/accessibility/AXLayoutObject.cpp:2026: SelectionHasNoDirection,
NotDispatchSelectEvent);
Why doesn't the direction depend on which one of the start and end pint is
larger to keep the distinction between anchor and focus even for text fields?

[blink-reviews, 2015-08-28 17:12:19]

Both recommendations adopted.

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Peter Lundblad, 2015-08-28 18:49:25]

lgtm

[nektarios, 2015-08-28 19:13:13]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-28 19:13:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314253002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314253002/60001

[commit-bot: I haz the power, 2015-08-28 19:14:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-28 19:14:42]

Dry run: Try jobs failed on following builders:
  linux_arm_compile on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compi...)

[dmazzoni, 2015-08-28 21:45:04]

lgtm

[nektarios, 2015-08-28 21:52:57]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2015-08-28 21:52:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
plundblad@chromium.org, dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1314253002/#ps80001
(title: "Fixed compiler error.")

[commit-bot: I haz the power, 2015-08-28 21:53:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314253002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314253002/80001

[commit-bot: I haz the power, 2015-08-28 23:21:53]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201438