Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 1314203002: [strong] Class constructor bodies cannot contain "use strong" directive (Closed)

Created:
5 years, 3 months ago by conradw
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] Class constructor bodies cannot contain "use strong" directive Since the constructor is also the class object itself, allowing it to retroactively become a strong object would have unintuitive consequences wrt the strength of the other functions of the class, and whether instances would be considered instances of a strong class. BUG=v8:3956 LOG=N Committed: https://crrev.com/05f01b3f8e2fbb2eac0f4495d165f928b2679570 Cr-Commit-Position: refs/heads/master@{#30519}

Patch Set 1 #

Patch Set 2 : fix rebase duplication #

Patch Set 3 : formatting #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -30 lines) Patch
M src/messages.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/parser.cc View 1 2 2 chunks +19 lines, -12 lines 0 comments Download
M src/preparser.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
M test/mjsunit/strong/function-arity.js View 3 chunks +0 lines, -18 lines 4 comments Download

Messages

Total messages: 10 (3 generated)
conradw
PTAL
5 years, 3 months ago (2015-08-26 15:39:42 UTC) #2
conradw
Adding some other reviewers since rossberg is at ICFP, this is blocking a couple of ...
5 years, 3 months ago (2015-09-01 08:09:35 UTC) #4
rossberg
LGTM modulo comment https://codereview.chromium.org/1314203002/diff/40001/test/mjsunit/strong/function-arity.js File test/mjsunit/strong/function-arity.js (left): https://codereview.chromium.org/1314203002/diff/40001/test/mjsunit/strong/function-arity.js#oldcode220 test/mjsunit/strong/function-arity.js:220: `'use strict'; I don't think you ...
5 years, 3 months ago (2015-09-01 16:52:40 UTC) #5
conradw
https://codereview.chromium.org/1314203002/diff/40001/test/mjsunit/strong/function-arity.js File test/mjsunit/strong/function-arity.js (left): https://codereview.chromium.org/1314203002/diff/40001/test/mjsunit/strong/function-arity.js#oldcode220 test/mjsunit/strong/function-arity.js:220: `'use strict'; On 2015/09/01 16:52:40, rossberg wrote: > I ...
5 years, 3 months ago (2015-09-01 16:55:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314203002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314203002/40001
5 years, 3 months ago (2015-09-01 16:58:38 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-01 18:29:31 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 18:29:42 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/05f01b3f8e2fbb2eac0f4495d165f928b2679570
Cr-Commit-Position: refs/heads/master@{#30519}

Powered by Google App Engine
This is Rietveld 408576698