Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2016)

Unified Diff: test/mjsunit/strong/function-arity.js

Issue 1314203002: [strong] Class constructor bodies cannot contain "use strong" directive (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: formatting Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-parsing.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/strong/function-arity.js
diff --git a/test/mjsunit/strong/function-arity.js b/test/mjsunit/strong/function-arity.js
index 8eddc5e4a73bc916790d6d7162601e9746dfea38..64d76c1ac0fe65fbefdaf3a6db3157fb65a1f80d 100644
--- a/test/mjsunit/strong/function-arity.js
+++ b/test/mjsunit/strong/function-arity.js
@@ -176,10 +176,6 @@ function generateSpread(n) {
let defs = [
`'use strong';
class C { constructor(${genParams(parameterCount)}) {} }`,
- `'use strict';
- class C {
- constructor(${genParams(parameterCount, true)}) { 'use strong'; }
- }`,
];
for (let def of defs) {
let calls = [
@@ -217,15 +213,6 @@ function generateSpread(n) {
super(${genArgs(argumentCount)});
}
}`,
- `'use strict';
rossberg 2015/09/01 16:52:40 I don't think you want to delete this test altoget
conradw 2015/09/01 16:55:54 My impression was that it would need to be deleted
- class B {
- constructor(${genParams(parameterCount, true)}) { 'use strong'; }
- }
- class C extends B {
- constructor() {
- super(${genArgs(argumentCount)});
- }
- }`,
];
for (let def of defs) {
let code = `${def}; new C();`;
@@ -253,11 +240,6 @@ function generateSpread(n) {
constructor(${genParams(parameterCount)}) {}
}
class C extends B {}`,
- `'use strict';
rossberg 2015/09/01 16:52:40 Same here perhaps.
conradw 2015/09/01 16:55:54 See above.
- class B {
- constructor(${genParams(parameterCount, true)}) { 'use strong'; }
- }
- class C extends B {}`,
];
for (let def of defs) {
let code = `${def}; new C(${genArgs(argumentCount)})`;
« no previous file with comments | « test/cctest/test-parsing.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698