Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: Source/core/editing/VisiblePosition.h

Issue 1313963003: Move honorEditingBoundaryAtOr{Before,After}() out from VisiblePosition class (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-31T14:15:42 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/editing/VisiblePosition.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/VisiblePosition.h
diff --git a/Source/core/editing/VisiblePosition.h b/Source/core/editing/VisiblePosition.h
index a12916cd0d75e9c25ec038f09f5a5358cd172a35..5b24202ab37ebb57124069265ce47af24549a65a 100644
--- a/Source/core/editing/VisiblePosition.h
+++ b/Source/core/editing/VisiblePosition.h
@@ -94,10 +94,6 @@ public:
PositionWithAffinity toPositionWithAffinity() const { return PositionWithAffinity(m_deepPosition, m_affinity); }
TextAffinity affinity() const { return m_affinity; }
- // next() and previous() will increment/decrement by a character cluster.
- VisiblePosition honorEditingBoundaryAtOrBefore(const VisiblePosition&) const;
- VisiblePosition honorEditingBoundaryAtOrAfter(const VisiblePosition&) const;
-
// TODO(yosin) This does not handle [table, 0] correctly.
Element* rootEditableElement() const { return m_deepPosition.isNotNull() ? m_deepPosition.anchorNode()->rootEditableElement() : 0; }
@@ -141,8 +137,14 @@ CORE_EXPORT PositionInComposedTree canonicalPositionOf(const PositionInComposedT
// "VisibleUnits.cpp"
UChar32 characterAfter(const VisiblePosition&);
UChar32 characterBefore(const VisiblePosition&);
+
+// TODO(yosin) We should move |honorEditingBoundaryAtOr{Before,After} to
+// "VisibleUnits.cpp" as static function.
+// next() and previous() will increment/decrement by a character cluster.
+VisiblePosition honorEditingBoundaryAtOrBefore(const VisiblePosition&, const Position& anchor);
PositionWithAffinity honorEditingBoundaryAtOrBeforeOf(const PositionWithAffinity&, const Position& anchor);
PositionInComposedTreeWithAffinity honorEditingBoundaryAtOrBeforeOf(const PositionInComposedTreeWithAffinity&, const PositionInComposedTree& anchor);
+VisiblePosition honorEditingBoundaryAtOrAfter(const VisiblePosition&, const Position& anchor);
// TODO(yosin) We should move |nextPositionOf()| to "VisibleUnits.cpp".
VisiblePosition nextPositionOf(const VisiblePosition&, EditingBoundaryCrossingRule = CanCrossEditingBoundary);
« no previous file with comments | « no previous file | Source/core/editing/VisiblePosition.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698